grats icon indicating copy to clipboard operation
grats copied to clipboard

chore: make typescript a peerDependency

Open radiosilence opened this issue 5 months ago • 1 comments

Pinning the internal version can cause havok when running npx grats, due various flags/configurations of tsconfig.json not being supported by older TS versions.

radiosilence avatar Jul 10 '25 15:07 radiosilence

Deploy Preview for grats failed. Why did it fail? →

Name Link
Latest commit d8cf01e26fbe1b768cdb18c236b35750c9ae640e
Latest deploy log https://app.netlify.com/projects/grats/deploys/686fdfe26bee230008931520

netlify[bot] avatar Jul 10 '25 15:07 netlify[bot]

Sorry I missed this. I know the problem you're highlighting, but I'm a little hesitant to take this on since there are places where we do poke (lightly) into private TypeScript APIs and I don't know that we can reliably trust those to behave stably on all versions of TypeScript.

That said, I like the idea of making both graphql and typescript peer dependencies long term since one of the values of Grats is that it has so few dependencies and the ones that are actually heavy are surely already dependencies you have.

I think a prerequisite for this would be to get our CI tests to run with several versions of TypeScript so that we can validate that we actually can safely run with arbitrary versions of TypeScript.

captbaritone avatar Dec 10 '25 03:12 captbaritone