relay icon indicating copy to clipboard operation
relay copied to clipboard

Fix render and dispose checks in useQueryLoader tests

Open monicatang opened this issue 1 year ago • 1 comments

Tests on renderCount would be testing React internals, which is unadvised since the tests may fail depending on the React version, and are probably ok to remove. But, these tests are testing Relay behavior -- whether queries are disposed upon re-render -- so I kept the React renderCount checks to clarify the expected render behavior that is triggering these query disposals.

I updated the renderCount to the correct number for React 19.

monicatang avatar Jul 12 '24 22:07 monicatang

@monicatang has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

facebook-github-bot avatar Jul 12 '24 22:07 facebook-github-bot

Closing since the diff internally was abandoned.

captbaritone avatar Jan 24 '25 00:01 captbaritone