facebook
Add node 18 in CI
Fixed : #3883
- Added node 18.x in ci.yml
- Added condition to export NODE_OPTION to suppress error of digital envelop with webpacker with node 18
Hi @nisargparikh69!
Thank you for your pull request and welcome to our community.
Action Required
In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.
Process
In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.
Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.
If you have received this in error or have any questions, please contact us at [email protected]. Thanks!
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!
Ok, just shifted export of env variable upwards to check if it works now
On Sat, Oct 7, 2023 at 4:47 AM Jordan Eldredge @.***> wrote:
Looks like the digital envelope issue is still present? [image: Screenshot 2023-10-06 at 4 16 27 PM] https://user-images.githubusercontent.com/162735/273347292-8ff96e9b-c41d-4ab7-995c-b1cab99f1c2e.png
— Reply to this email directly, view it on GitHub https://github.com/facebook/relay/pull/4457#issuecomment-1751492543, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGDKVCWCTO7YWHKLIBSACULX6CGQHAVCNFSM6AAAAAA5PNWJFSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJRGQ4TENJUGM . You are receiving this because you were mentioned.Message ID: @.***>
-- Thanks & Regards, Nisarg Parikh
Looks like the digital envelope issue is still present. We also maybe need to add v20, and drop v14.
Fro the node website (https://github.com/nodejs/release#release-schedule):
| Release | Status | Codename | Initial Release | Active LTS Start | Maintenance LTS Start | End-of-life |
|---|---|---|---|---|---|---|
| 14.x | End-of-Life | Fermium | 2020-04-21 | 2020-10-27 | 2021-10-19 | 2023-04-30 |
