freebsd-src icon indicating copy to clipboard operation
freebsd-src copied to clipboard

MFC ice(4): Update to 1.42.1-k

Open kgalazka opened this issue 11 months ago • 2 comments

Summary:

  • Adds E830 device support
  • Adds pre-release E825C support (for the Ethernet device included in an upcoming Xeon D platform)
  • Add sysctl for E810 devices to print out PHY debug statistics (mostly for FEC debugging)
  • Adds per-TX-queue tso counter sysctl to count how many times a TSO offload was requested for a packet, matching other Intel drivers
  • Various bug fixes

ice_ddp: Update to 1.3.41.0

kgalazka avatar Jan 27 '25 23:01 kgalazka

Would you be willing to put the new information in ice(4)? Alternatively, if you'd rather explain it a little more, I would be happy to do it.

concussious avatar Jan 29 '25 03:01 concussious

Would you be willing to put the new information in ice(4)? Alternatively, if you'd rather explain it a little more, I would be happy to do it.

I appreciate you offer but I think I should be able to grab something from out-of-tree version of the man page. I'll try to upload at least a draft this week. If you could help with review, that would be great.

kgalazka avatar Jan 29 '25 21:01 kgalazka

Is this ready to go into stable/14? We dont' normally do pull requests for MFCs, but this might be a good exception.

bsdimp avatar Jul 23 '25 14:07 bsdimp

Is this ready to go into stable/14? We dont' normally do pull requests for MFCs, but this might be a good exception.

This PR was my (desperate) attempt to get ICE update into 13.5-RELEASE after Eric left Intel. I wasn't yet honored with a commit bit, so I wasn't able to do it myself. I thought PR could be good way to ensure there are no merge conflicts and get Eric's approval before asking for help with the actual MFC. It didn't go as planned due to a lack of a man page update pointed out by Alexander, which I failed to address on time.

@ricera and @concussious - are you okay with pushing this as is, and updating the manual later when Eric's PR #1622 is ready?

kgalazka avatar Jul 23 '25 19:07 kgalazka

I'm ok updating w/o a man page if there's active work on it elsewhere. We often needlessly block things for that and create too much complication. I think this is one of those cases. Of course, we often commit w/o a man page and never update (which we're trying to improve), but I think that it's worth this risk on this device.

bsdimp avatar Jul 23 '25 19:07 bsdimp

I don't want to block, I just want to encourage the doc, so that the great work sees usage and adoption[^1]. Thank you so much for this!

[^1]: Well also doing the doc brings clarity to myriad things which can help the development process. Sometimes layers of things get built with no doc and then trying to document it later, which takes much longer, it's clear that the behavior is extremely convoluted that wouldn't have happened if we had doc consistently the whole time.

concussious avatar Jul 23 '25 20:07 concussious

Is this ready to go into stable/14? We dont' normally do pull requests for MFCs, but this might be a good exception.

This PR was my (desperate) attempt to get ICE update into 13.5-RELEASE after Eric left Intel. I wasn't yet honored with a commit bit, so I wasn't able to do it myself. I thought PR could be good way to ensure there are no merge conflicts and get Eric's approval before asking for help with the actual MFC. It didn't go as planned due to a lack of a man page update pointed out by Alexander, which I failed to address on time.

@ricera and @concussious - are you okay with pushing this as is, and updating the manual later when Eric's PR #1622 is ready?

I'm fine with it; we should get this in for the E830 support.

ricera avatar Jul 23 '25 23:07 ricera

With Alexander's and Eric's approval I exercised my commit bit and pushed this update to stable/13. Closing PR.

kgalazka avatar Jul 24 '25 14:07 kgalazka