Andrew Scott

This PR was merged into the repository by commit 0198d21231565f5eeaa27a871b9bb9e950b4a869.

The reason it's not a type error is that modules and components are both classes. We can't distinguish between the two in the type system. That said, the runtime check...

@Ivnosing I was thinking that instead you can look at the instance type of the item and see if it's a module to provide a different message that doesn't say...

For reference, there was previous conversation around whether it would be better to throw an error rather than return `null`. https://github.com/angular/angular/pull/39632#issuecomment-1031774045 Returning `null` aligns with `document.querySelector` and has an easier...

Hi @tomalaforge - In general, I think this change looks correct and it's a great improvement. That said, it's absolutely a breaking change since the type is more restrictive. There...

[passing TGP](https://fusion2.corp.google.com/presubmit/tap/515740794/OCL:515740794:BASE:518857534:1679582896050:e5b9155f/targets)

This PR was merged into the repository by commit d47fef72cb497db555e67db50997b3b1cc3ee590.

Given that `ClassWithCtorArgs` is much more common than classes with generics, I this feels like a regression in the majority of cases. Adding the blocked label until this issue is...

@markostanimirovic We will not have time to work on a migration for v16.

Per discussions in this PR, the fix here is a regression in the more common cases. The ideal path forward is to remove the overload with `token: any`