Andrew Scott

Results 123 comments of Andrew Scott

> Would it be useful if I sent in more PRs for some of the router TODOs? I would love to help out further but I wouldn't want to waste...

Are you using the latest version of the extension? The latest version of the extension is required because it bundles the Angular compiler and host directives were not supported pre-v15....

@wellwind We did find some issues while investigating this. All inputs from the directive will be available in autocompletion (even if they're not listed in the hostDirective inputs). Also, host...

This is working as expected. The application is misconfiguring `APP_BASE_HREF` and the `` element. Your `APP_BASE_HREF` results in the router prepending `//${ location.host }/${ root }/${ locale }/` to every...

It looks like you want your `APP_BASE_HREF` to be `/cdn-i18n-routing-issue/{locale}/`. Does that resolve the issue?

@constantant indeed, this is an issue. I'm surprised this isn't encountered more frequently. The `Location` is totally incapable of correctly processing a `base` href with an origin because it attempts...

Note that you can work around this by forking `Location` and updating `_stripBaseHref` to handle your `baseHref` correctly (and then adding your fork to your `providers` for `Location`)

@constantant would you like to contribute a PR to fix this in @angular/common? https://github.com/angular/angular/blob/fd2eea59613ab3cdde871046b6086216d77a386e/packages/common/src/location/location.ts#L71

Yes, this is absolutely true. Standalone features only just exited developer preview in the v15 release. We still have an item on our backlog to update documentation. But rest assured,...

I see. It appears that the real issue is that `errorHandler` currently provides a way to handle navigation errors separately from other errors. Since there is no clearly identifiable information...