Andrew Scott

Results 123 comments of Andrew Scott

[TGP](https://fusion2.corp.google.com/presubmit/565230882/OCL:565230882:BASE:566289104:1695076718357:9d7409a9/targets) - seems like maybe a handful of root causes that might be fixable by hand

> So I was really wondering about their usage and if the 2 version depreciation period was necessary ! Unless they were officially already deprecated in v11, yes

> Am I correct to assume there isn't so much we can do here because of compileNonExportedClasses : false That's correct. I'll leave this open as a potential for having...

@JeanMeche can you resolve conflicts? There are no uses of this internally

caretaker note: The BUILD file for this package needs to be manually deleted when merging internally.

This PR was merged into the repository by commit c2f270cf147e6434957e3b259ddc54a54a2a590e.

Yea, definitely. In the meantime, here's a fancy router outlet to play with (the router API does allow for custom router outlets): https://stackblitz.com/edit/angular-fcnbwy-7rkfyz?file=src%2Fapp%2Ffancy_router_outlet.ts. I wouldn't be surprised if it has...

@konstantindenerz Thanks for the input. Please note that the outlet implementation is absolutely not a proposal for how it should be implemented. However, it is in user-space and can be...

I do think this is a good idea in general. Truthfully, it's not limited to the `Router` or `RouterTestingHarness`, but more of a general problem with `TestBed` and its integration...

TL;DR Yes, navigations in tests should automatically trigger change detection. But this should be through the same scheduling mechanism used in the application, not the `RouterTestingHarness` forcing `detectChanges`. After working...