Andrew Scott comments

Results 123 comments of


Andrew Scott

fix(core): infer correct return type when `inject` is used with generic classes

I think I misunderstood the comment history here. The correct fix requires this change _and_ the removal of the deprecated `any` overload. Is that correct @markostanimirovic?

Several dependency updates.

This PR was merged into the repository by commit 208f52209bfc2425c90752e795704c08435d4d77.

refactor(router): Move more transition logic into the transition handler

caretaker note: probably want to merge and sync this on its own

refactor(router): Move more transition logic into the transition handler

This PR was merged into the repository by commit afc668acd5eef711639dcdb4979acad6c99b8ae3.

refactor(router): Move more transition logic into the transition handler

[TGP](https://fusion2.corp.google.com/presubmit/tap/491486226/OCL:491486226:BASE:491707794:1669753610675:92c2d3bc;groups=PossiblyNewlyFailing/targets). The failing tests are accessing `navigationId`, which is not a valid use-case. A temporary private getter has been added while this is cleaned up internally. Merging can be resumed.

refactor(router): Move more transition logic into the transition handler

**Caretaker Note:** Please ignore the `google-internal-tests` status. Failures are pre-existing. Deflaking does not change this.

refactor(router): Move more transition logic into the transition handler

This PR was merged into the repository by commit 0ff5d972cdd20428d647a94c6c769c0759cfd49c.

Upgrade NG13 -> NG14/15 Error: Providers from the `BrowserModule` have already been loaded

Please provide a minimal reproduction, either in stackblitz or a github repo. Without this, we cannot effectively determine the what's causing the issue.

Upgrade NG13 -> NG14/15 Error: Providers from the `BrowserModule` have already been loaded

@patrickritskes An approach that usually works is to gradually delete modules from your application until you get to a point where the error disappears. Then you'll know where the error...

Upgrade NG13 -> NG14/15 Error: Providers from the `BrowserModule` have already been loaded

Thanks for the update. Closing as resolved.