Yagiz Nizipli

Results 450 comments of Yagiz Nizipli

Thanks for the review @pauldreik. I'll address them soon.

> Just for my education, does it really change the assembly emitted by compilers. This seems trivial to optimize but I don't know much about it 🙈 Yes. The if...

@AVVS you need to update your commit message according to the requirements

@aduh95 can you fix the commit message? let's merge this to unblock the pr for replacing Promise.withResolvers

Nest wired camera doesn't work with HomeKit as well.

If there is one review after the last force push, then CQ will merge it, right? I think it's still open to abuse (and a bug).

If person X opens a pull-request and receive 2+ reviews (from Y and Z), he could force-push couple of hours before the 48 hour window. There is a pattern of...

@aduh95 For example: I force pushed, nobody reviewed it, and it still got merged by CQ. (Reference: https://github.com/nodejs/node/pull/46904)

74 files is almost impossible to review for me.