node icon indicating copy to clipboard operation
node copied to clipboard

fix(node_http2.cc): remove duplicate codeblock

Open AVVS opened this issue 1 year ago β€’ 10 comments

Original bug was introduced in here: https://github.com/nodejs/node/pull/55155/files#diff-33f026e43570112875cf4c8eab6743496f3aa014329611128e348ec23d6f771cL1303-R1313 Doesn't seem like that it actually leads to any problems, except extra memcpy

AVVS avatar Nov 19 '24 04:11 AVVS

Review requested:

  • [ ] @nodejs/http2
  • [ ] @nodejs/net

nodejs-github-bot avatar Nov 19 '24 04:11 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63628/

nodejs-github-bot avatar Nov 19 '24 04:11 nodejs-github-bot

@AVVS you need to update your commit message according to the requirements

anonrig avatar Nov 19 '24 05:11 anonrig

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 88.50%. Comparing base (1d01ad6) to head (6cefd81). Report is 1462 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #55915      +/-   ##
==========================================
+ Coverage   88.01%   88.50%   +0.49%     
==========================================
  Files         653      653              
  Lines      187735   187731       -4     
  Branches    35874    36184     +310     
==========================================
+ Hits       165229   166149     +920     
+ Misses      15693    14811     -882     
+ Partials     6813     6771      -42     
Files with missing lines Coverage Ξ”
src/node_http2.cc 84.83% <ΓΈ> (+0.11%) :arrow_up:

... and 94 files with indirect coverage changes

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Nov 19 '24 06:11 codecov[bot]

updated commit message

AVVS avatar Nov 19 '24 16:11 AVVS

CI: https://ci.nodejs.org/job/node-test-pull-request/63635/

nodejs-github-bot avatar Nov 19 '24 17:11 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63696/

nodejs-github-bot avatar Nov 25 '24 08:11 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63705/

nodejs-github-bot avatar Nov 26 '24 03:11 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63766/

nodejs-github-bot avatar Nov 29 '24 06:11 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/63887/

nodejs-github-bot avatar Dec 05 '24 02:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/64008/

nodejs-github-bot avatar Dec 11 '24 17:12 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/64022/

nodejs-github-bot avatar Dec 12 '24 13:12 nodejs-github-bot

Landed in 131c33efa56ce7630bf9d25e5b8c3467b5f142ed

nodejs-github-bot avatar Dec 12 '24 14:12 nodejs-github-bot