node icon indicating copy to clipboard operation
node copied to clipboard

deps: V8: backport 0d5d6e71bbb0

Open aduh95 opened this issue 1 year ago • 9 comments

Original commit message:

Remove `--js-promise-withresolvers` runtime flag

Co-authored-by: Antoine du Hamel <[email protected]>
Bug: 42204122
Change-Id: I017a0d1ae0f8225513206ffb7806a4250be75d4c
Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5843972
Reviewed-by: Igor Sheludko <[email protected]>
Commit-Queue: Erik Corry <[email protected]>
Reviewed-by: Shu-yu Guo <[email protected]>
Cr-Commit-Position: refs/heads/main@{#96215}

Refs: https://github.com/v8/v8/commit/0d5d6e71bbb0d2b0a12567fffa7e3375c427bc92

aduh95 avatar Sep 25 '24 09:09 aduh95

Review requested:

  • [ ] @nodejs/gyp
  • [ ] @nodejs/security-wg
  • [ ] @nodejs/v8-update

nodejs-github-bot avatar Sep 25 '24 09:09 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6213/

nodejs-github-bot avatar Sep 25 '24 14:09 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6213/

nodejs-github-bot avatar Sep 25 '24 14:09 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6213/

nodejs-github-bot avatar Sep 25 '24 14:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/62792/

nodejs-github-bot avatar Sep 26 '24 21:09 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu2204-intel-64,v8test=v8test/6217/

nodejs-github-bot avatar Sep 26 '24 21:09 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/6217/

nodejs-github-bot avatar Sep 26 '24 21:09 nodejs-github-bot

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/6217/

nodejs-github-bot avatar Sep 26 '24 21:09 nodejs-github-bot

CI: https://ci.nodejs.org/job/node-test-pull-request/62798/

nodejs-github-bot avatar Sep 27 '24 10:09 nodejs-github-bot

@aduh95 can you fix the commit message? let's merge this to unblock the pr for replacing Promise.withResolvers

anonrig avatar Oct 03 '24 13:10 anonrig

CI: https://ci.nodejs.org/job/node-test-pull-request/62904/

nodejs-github-bot avatar Oct 03 '24 14:10 nodejs-github-bot

an you fix the commit message?

I don't think the commit message needs fixing, it's the bot that is wrong.

aduh95 avatar Oct 03 '24 15:10 aduh95

I don't know if the goal is to land this on v22.x, but it doesn't land cleanly at all.

targos avatar Oct 04 '24 07:10 targos