Yagiz Nizipli comments

Results 470 comments of


                                            Yagiz Nizipli

adding cargo-semver-checks

I'm more than happy to move to workflow based publishing. Do you have any recommendation/example with semver-checks?

adding cargo-semver-checks

> Hello, can i work on this ? Thanks Yes. feel free to open a PR

native node:* modules implemented in workerd

node:perf_hooks pull-request also contains global classes which are polyfilled by unenv.

add shrink() to kj::String and kj::ConstString

I'm thinking about adding a shrink() method to kj::Array as well so we can get away from copying while shrinking. What do you think @mikea?

add KJ_ASSERT_SOME and KJ_REQUIRE_SOME

Yes that's my intention @kentonv

url: runtime deprecate url.parse

> safe modules that will be affected by this for no good reason. Even in the deprecation note says that it's not recommended and safe to use it. How can...

url: runtime deprecate url.parse

> I think we should be doing what we have done for Buffer, emitting a warning only if the code is not inside node_modules. I updated the code as recommended....

Self-serve model for funding Node.js work

> can any of you who have added the "Sponsor me" links indicate whether that has actually been effective for you? @jasnell I didn't had any new sponsors at all...

add bazel config file

> Can you elaborate more on the purpose of this change? Having a BAZEL.build and `tests.bzl` a inside here, but not on implementors, would allow glob files to be exported...

add bazel config file

> At least there should be documentation somewhere in the repo what this is for Where do you suggest adding that?