Yagiz Nizipli
Yagiz Nizipli
@jasnell @trivikr @atlowChemi please rereview since the changes you approved are no longer the same.
@RedYetiDev what is the motivation for this change, please add it to your description for reviewers
Can you add the appropriate documentation as well?
I think this was a cache issue. While testing my previous PR, the message changed.
cc @nodejs/build @nodejs/performance please take a look
> Just as a question, do we distribute binaries built w/ gcc? Yes, I think so, but @nodejs/build can answer this better than me.
> Have you measured it in different environments? Only macOS for now. I can measure it on Linux tomorrow, if someone doesn't beat me to it. Please run and share...
I tried enabling PGO as well, and it didn't make a difference at all. Maybe we are missing something @joyeecheung
> If -ffunctions and -fdata-sections is passed, should be not also --gc-sections passed to the linker? @ptr1337 I found some examples of `--gc-sections` not optimizing correctly. https://stackoverflow.com/questions/31521326/gc-sections-discards-used-data Is this not...
> Indeed, windows-1252 is not exactly the same as latin-1. How is it that the `DecodeLatin1` is called for that encoding? [@anonrig](https://github.com/anonrig) According to MDN, latin1 is as same as...