Yagiz Nizipli

Results 447 comments of Yagiz Nizipli

> Thanks for this > > Was the benchmark in a release build? Yes @Jarred-Sumner

> looks like the test [test/bundler/bundler_cycle_detection.test.ts](https://github.com/oven-sh/bun/blob/438cd79470ff77123b329ba40f92a54a19077ad3/test/bundler/bundler_cycle_detection.test.ts) is failing in all platforms, the other failures are not related It seems I've written the include path wrong in the first place. Can...

> https://github.com/search?type=code&q=%22node%3A%3AEnvironment%3A%3AGetCurrent%28%22+language%3AC%2B%2B&l=C%2B%2B I see that most usage comes from Electron. Although, this might look like a breaking change, this function isn't exposed using similar. I wonder if semver-major holds for...

~~@npaun It seems `assert_throws_js` implementation is wrong. Here's the Node.js implementation: https://github.com/nodejs/node/blob/8807549ed9f6eaf6842ae56b8ac55ab385951636/test/fixtures/wpt/resources/testharness.js#L2046~~ Completed in https://github.com/cloudflare/workerd/pull/3157

~~Additional issue: @npaun If a test is in `expected_failures` but if it doesn't fail, we should also throw an error.~~ Completed in https://github.com/cloudflare/workerd/pull/3157

@Jarred-Sumner @cirospaciari can you take a look?

Would be helpful where memory is extremely constrained, and over allocation is not advised.

@targos I'm getting a runtime error with this. Am I missing something? ``` NOTE: The test started as a child_process using these flags: [ '--expose-internals', '--no-warnings', '--allow-natives-syntax' ] Use NODE_SKIP_FLAG_CHECK...

> > I'm getting a runtime error with this. Am I missing something? > > I think it's because you can't directly optimize a native function. You need to wrap...

@targos any idea why this test is failing on arm-debug?