Yagiz Nizipli
Yagiz Nizipli
@lemire I wonder if installing gtest directly to alpine linux would solve our problem? It seems it's available: https://pkgs.alpinelinux.org/package/edge/main/x86/gtest
cc @nodejs/cpp-reviewers @nodejs/tsc would you mind reviewing?
@jasnell @mcollina would you mind reviewing this PR? is it a good idea or a bad one, i'm not sure.
> I expect problems in windows, but if we can get it to pass on CI it's ok. This PR doesn't update Windows implementation. Only UNIX
cc @aduh95 @cjihrig can you re-review? I've addressed your comments.
> @anonrig could this have any impact on pref? > > Should any benchmarks be run? I think it will improve performance but I'm not sure. Once the tests pass,...
> `PromiseWithResolvers` isn't in primordials yet, is it? It seems like it can be removed by a v8 flag: https://github.com/v8/v8/blob/3b12a031d2293acf01872e213473c8657671c8db/src/init/bootstrapper.cc#L5585
I added PromiseWithResolvers to `primordials.js`, I think we can land this now.
@MoLow reviewed it faster than I requested a review. I have nothing but utter respect for you!
> the primordial can be polyfilled tho without providing it on the global, which would allow backporting? I polyfilled it 👍