Aimane Chnaif

Results 118 comments of Aimane Chnaif

@shahinyan11 if you wanna demo, it's fine to create your own branch but don't make PR. Create **draft** PR at maximum. Don't mark as ready which auto-assigns people.

> @aimane-chnaif How to crate draft PR and Don't mark as ready . https://github.blog/2019-02-14-introducing-draft-pull-requests/

This is super simple but let's still follow proposal template (this is not dib issue like TS migration)

@esh-g's first Proposal: https://github.com/Expensify/App/issues/35677#issuecomment-1924302082 🎀 👀 🎀 C+ reviewed

yes, PR should have been reached production already but this is edge case as we won't be deploying this week.

> @ZhenjaHorbach I have original file, but unable to attach to GH > > ![image](https://private-user-images.githubusercontent.com/93399543/299788379-3e61a6ed-7b3e-41f4-9002-5ec07b703350.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MDY3MjQ3MDUsIm5iZiI6MTcwNjcyNDQwNSwicGF0aCI6Ii85MzM5OTU0My8yOTk3ODgzNzktM2U2MWE2ZWQtN2IzZS00MWY0LTkwMDItNWVjMDdiNzAzMzUwLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDAxMzElMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwMTMxVDE4MDY0NVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPTlmNWQ2NmU2ZGFmOTZkODRlMmFhZDFlOWQwNWIzMDU2NmUxM2MzMTNmYTRiYzQ4ZGU1ZjlmN2NmNWUyNDEwMzkmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.gmWTv-OVxxhMr984-tZQSDVimPkyt5_hWGddQiMfU9k) @kbecciv Can you please upload to cloud somewhere (i.e. google drive) and share link?

Here's image: https://drive.google.com/file/d/1EkOCX20cD_JAHVa-HhKiu5d-B3b5Qucb/view?usp=sharing