Aimane Chnaif
Aimane Chnaif
> [This change](https://github.com/Expensify/App/pull/17349/commits/a6c58d6bcafc3978abcb21f06baf927b5bde2f22) should prevent the issue described https://github.com/Expensify/App/issues/16739#issuecomment-1498682840, i.e. make sure personal details data is ready before trying to create list options. Let me know what you think. @jczekalski...
@alitoshmatov thanks for your proposal but that will easily break style inside text. For contributors: - please explain in detail how to prevent style break in inline text - please...
For confirmation: we don't need to show circle background in wrapper when hovered, right? Correct I believe because if we add it, there should be space between email and copy...
> Ah, I was thinking of that as well. To maintain consistency in other places, I'd say it should also show a background when hovered 👍 ok then no acceptable...
I had same [opinion](https://github.com/Expensify/App/issues/16574#issuecomment-1501180838) as @allroundexperts. I'd like to get what design team thinks about this inconsistency. cc: @shawnborton
> Just as an FYI, we're using the same component below as well. yup, these are all pages which have copy icon: https://github.com/Expensify/App/pull/17008#pullrequestreview-1375634404
I suggest to put this on hold since popover including FAB menu will be completely refactored in #15289
Looking at them now
1. MenuItem 2. MenuItem2 3. OptionRow 4. LHN 5. Form error 6. Input error 7. Message 8. OfflineWithFeedback 9. ContactMethodDetailsError 10. ContactMethodDetailsSuccess 11. ContactMethodDetailsFailure 12. Header 13. Avatar These are...
> I kind of think we should just make them all 20x20 @joelbettner let's update Expected Result as per discussion. This is straight forward issue and @Prince-Mendiratta responded first with...