Aimane Chnaif
Aimane Chnaif
@jczekalski please pull from main
> @aimane-chnaif will you be able to review/test today? yes
@jczekalski Did you push all the changes? I don't think PR fixes main bugs happening on search, money request pages. Showing skeleton forever, app crashes very often https://user-images.githubusercontent.com/96077027/233257777-db70f0f1-d7b8-4280-b260-342fbe2adf8f.mov https://user-images.githubusercontent.com/96077027/233257807-4a1f81d9-e7b9-41e3-925f-0694806d1126.mov https://user-images.githubusercontent.com/96077027/233257817-3d1ad07b-28f9-4536-9c54-daec0a4ecf24.mov
Also please pull from main and fix conflicts
Also let's make sure that our PR fixes https://github.com/Expensify/App/issues/17293, https://github.com/Expensify/App/issues/16739 which were closed in favor of our issue. So please follow their reproducible steps and fix them. The root cause...
Let's fix https://github.com/Expensify/App/issues/16739 https://user-images.githubusercontent.com/96077027/233346385-2ace95fc-77ff-4b1e-8dc0-cc1a60303c4d.mov
Let's fix https://github.com/Expensify/App/issues/17293 https://user-images.githubusercontent.com/96077027/233346598-1c6aceb8-6d45-4116-9700-033283e352f7.mov
> I can't reproduce this issue on my branch, even with an incredibly slow connection. It's not constantly reproducible. The reason is explained [here](https://github.com/Expensify/App/issues/16739#issuecomment-1498682840). As I [stated](https://github.com/Expensify/App/issues/14490#issuecomment-1505280767) in proposal review,...
yes, in review. will post updates today
@amyevans can you please confirm if following pages should also be fixed here? Workspace members, Settings Right now, Workspace members page crashes, Settings page shows blank when go to those...