[$150] [Wave 8] [Ideal Nav] Change the global create and DM create tooltips to read `Create`

[trjExpensify]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: v1.4.36-0 Reproducible in staging?: Y Reproducible in production?: Y If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: @muttmuure Slack conversation: https://expensify.slack.com/archives/C036QM0SLJK/p1706889045249449

Action Performed:

1. Open NewDot on web/desktop
2. Hover over the + button in the bottom tab bar
3. Observe the tooltip reads New
4. Click into a chat
5. Hover over the + button to the left of the composer
6. Observe the tooltip reads Actions

Expected Result:

Standardise on displaying the tooltip in both places as: Create

Actual Result:

As described above, we have an inconsistency where we use New and Actions.

Workaround:

N/A

Platforms:

Which of our officially supported platforms is this issue occurring on?

• [ ] Android: Native
• [ ] Android: mWeb Chrome
• [ ] iOS: Native
• [ ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

Add any screenshot/video evidence

View all open jobs on GitHub

Upwork Automation - Do Not Edit

• Upwork Job URL: https://www.upwork.com/jobs/~0121d4f02863128339
• Upwork Job ID: 1753465553597399040
• Last Price Increase: 2024-02-02
• Automatic offers:
• aimane-chnaif | Reviewer | 28149278
• esh-g | Contributor | 28149279

[melvin-bot[bot]]

Job added to Upwork: https://www.upwork.com/jobs/~0121d4f02863128339

[melvin-bot[bot]]

Triggered auto assignment to Contributor-plus team member for initial proposal review - @aimane-chnaif (External)

[melvin-bot[bot]]

Triggered auto assignment to @zanyrenney (NewFeature), see https://stackoverflowteams.com/c/expensify/questions/14418#:~:text=BugZero%20process%20steps%20for%20feature%20requests for more details.

[esh-g]

Proposal

Please re-state the issue we are trying to solve

Change the global create and DM create tooltips to read Create

Root cause

N/A

Solution

We need to modify translation here: https://github.com/Expensify/App/blob/e6ea03b9278029acacb424856b58dee2d1134d9d/src/components/FloatingActionButton.tsx#L106

And here: https://github.com/Expensify/App/blob/e6ea03b9278029acacb424856b58dee2d1134d9d/src/pages/home/report/ReportActionCompose/AttachmentPickerWithMenuItems.js#L279

To a new common.create translation

[aimane-chnaif]

This is super simple but let's still follow proposal template (this is not dib issue like TS migration)

[trjExpensify]

Yeah, open to anyone. I dropped the price because it's so simple. :)

[allgandalf]

Proposal

Please re-state the problem that we are trying to solve in this issue.

Change the global create and DM create tooltips to read Create

What is the root cause of that problem?

Change name

What changes do you think we should make in order to solve the problem?

remove new and add create

https://github.com/Expensify/App/blob/e6ea03b9278029acacb424856b58dee2d1134d9d/src/languages/en.ts#L125

What alternative solutions did you explore? (Optional)

N/A

[aimane-chnaif]

@trjExpensify can we also get Spanish copy?

[aimane-chnaif]

@esh-g's first Proposal: https://github.com/Expensify/App/issues/35677#issuecomment-1924302082 🎀 👀 🎀 C+ reviewed

[melvin-bot[bot]]

Triggered auto assignment to @youssef-lr, see https://stackoverflow.com/c/expensify/questions/7972 for more details.

[trjExpensify]

I've asked internally about the Spanish translation here.

[trjExpensify]

Spanish translation is confirmed to be: Crear

[trjExpensify]

@youssef-lr can you give this proposal a secondary look so we can move it on? Thanks!

[youssef-lr]

Done @trjExpensify

[melvin-bot[bot]]

📣 @aimane-chnaif 🎉 An offer has been automatically sent to your Upwork account for the Reviewer role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job

[melvin-bot[bot]]

📣 @esh-g 🎉 An offer has been automatically sent to your Upwork account for the Contributor role 🎉 Thanks for contributing to the Expensify app!

Offer link Upwork job Please accept the offer and leave a comment on the Github issue letting us know when we can expect a PR to be ready for review 🧑‍💻 Keep in mind: Code of Conduct | Contributing 📖

[zanyrenney]

Can't we close this if merged? @trjExpensify

[zanyrenney]

Or payouts still needed?

[trjExpensify]

PR is only on staging, so next steps::

• PR needs to go to production
• 7 day regression period will kick in
• All being well, we'll pay out on tat day and close the issue.

[zanyrenney]

Ah, it looked 2 weeks old for me: @esh-g esh-g mentioned this issue 2 weeks ago

[aimane-chnaif]

yes, PR should have been reached production already but this is edge case as we won't be deploying this week.

[trjExpensify]

Right, we've had a deploy freeze because of the earnings call.

[trjExpensify]

PR is now on production as of yesterday. Adjusting the title to reflect the 7 day hold.

[trjExpensify]

Payment summary as follows:

• $150 to @esh-g for the fix
• $150 to @aimane-chnaif for the C+ review

Paid out both, closing!