App
App copied to clipboard
Expensify
[HOLD for payment 2024-01-31] Web - Chat - Cursor shows a hand instead of a text cursor "I" when hovering over text in code block
If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!
**Version Number:**1.3.97-1 Reproducible in staging?: Y Reproducible in production?: N If this was caught during regression testing, add the test name, ID and link from TestRail: Email or phone of affected tester (no customers): Logs: https://stackoverflow.com/c/expensify/questions/4856 Expensify/Expensify Issue URL: Issue reported by: Applause - Internal Team Slack conversation:
Action Performed:
- Navigate to staging.new.expensify.com
- Go to any chat
- Send a code block
- Hover over code block
Expected Result:
The cursor shows a text cursor "I"
Actual Result:
The cursor shows a hand cursor
Workaround:
Unknown
Platforms:
Which of our officially supported platforms is this issue occurring on?
- [ ] Android: Native
- [ ] Android: mWeb Chrome
- [ ] iOS: Native
- [ ] iOS: mWeb Safari
- [x] Windows: Chrome
- [ ] MacOS: Desktop
Screenshots/Videos
Add any screenshot/video evidence
https://github.com/Expensify/App/assets/78819774/1022e4a4-a9e3-49fd-8631-4614bca9e06c
Triggered auto assignment to @sophiepintoraetz (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details.
![melvin-bot[bot] avatar](https://avatars.githubusercontent.com/in/179547?v=4 "Published by a pub.dev verified publisher"){kind=small}
Bug0 Triage Checklist (Main S/O)
- [ ] This "bug" occurs on a supported platform (ensure
Platformsin OP are ✅) - [ ] This bug is not a duplicate report (check E/App issues and #expensify-bugs)
- If it is, comment with a link to the original report, close the issue and add any novel details to the original issue instead
- [ ] This bug is reproducible using the reproduction steps in the OP. S/O
- If the reproduction steps are clear and you're unable to reproduce the bug, check with the reporter and QA first, then close the issue.
- If the reproduction steps aren't clear and you determine the correct steps, please update the OP.
- [ ] This issue is filled out as thoroughly and clearly as possible
- Pay special attention to the title, results, platforms where the bug occurs, and if the bug happens on staging/production.
- [ ] I have reviewed and subscribed to the linked Slack conversation to ensure Slack/Github stay in sync
:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open StagingDeployCash deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:
- Identify the pull request that introduced this issue and revert it.
- Find someone who can quickly fix the issue.
- Fix the issue yourself.
Triggered auto assignment to @tylerkaraszewski (Engineering), see https://stackoverflow.com/c/expensify/questions/4319 for more details.
Hmm, I'm not able to reproduce this and I don't think this is a deploy blocker - @tylerkaraszewski - do you agree?
Proposal
Please re-state the problem that we are trying to solve in this issue.
Pointer cursor shows instead of text cursor when hovering over the code block
What is the root cause of that problem?
We removed the role 'text' and use 'presentation' instead(from the PR https://github.com/Expensify/App/pull/24482) But we're still use 'text' below to set the cursor https://github.com/Expensify/App/blob/a63a8962ed3a1ba38de278b4331bbb655104ca7f/src/components/Pressable/GenericPressable/BaseGenericPressable.tsx#L135
Also we replaced the accessibilityRole with role in the same PR, but we're still using accessibilityRole below
https://github.com/Expensify/App/blob/dee9b3110a7ebe0aa250c3f966d6a69925d916f4/src/components/Pressable/GenericPressable/index.tsx#L14
This is the root cause
What changes do you think we should make in order to solve the problem?
We should use the CONST.ACCESSIBILITY_ROLE.TEXT instead of `text' here
https://github.com/Expensify/App/blob/a63a8962ed3a1ba38de278b4331bbb655104ca7f/src/components/Pressable/GenericPressable/BaseGenericPressable.tsx#L135
And remove this line https://github.com/Expensify/App/blob/dee9b3110a7ebe0aa250c3f966d6a69925d916f4/src/components/Pressable/GenericPressable/index.tsx#L14
This works as expected
Result
https://github.com/Expensify/App/assets/126839717/b7ab3e65-c1e1-402d-aeb2-a12b4528227d
What alternative solutions did you explore? (Optional)
@sophiepintoraetz
This issue is reproducible in staging(version: 1.3.97-1), but not in production.
@sophiepintoraetz
Yeah. It looks like you used "`". Please try with "```"
@sophiepintoraetz @tylerkaraszewski
Yeah. It looks like you used "`". Please try with "```"
There are some other places we need to replace(accessibilityRole -> role)
This is pretty minor, I am going to remove the deploy blocker tag and assign @getusha to fix it.
@tylerkaraszewski, @sophiepintoraetz, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
@tylerkaraszewski, @sophiepintoraetz, @getusha Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
This issue has not been updated in over 15 days. @tylerkaraszewski, @sophiepintoraetz, @getusha eroding to Monthly issue.
P.S. Is everyone reading this sure this is really a near-term priority? Be brave: if you disagree, go ahead and close it out. If someone disagrees, they'll reopen it, and if they don't: one less thing to do!
Has this been abandoned? Should we re-assign it? What's going on with the PR?
@narefyev91 was C+ reviewer in PR but he's now not in C+ team. I can take over if needed
@tylerkaraszewski, @sophiepintoraetz, @getusha, @situchan Whoops! This issue is 2 days overdue. Let's get this updated quick!
@tylerkaraszewski, @sophiepintoraetz, @getusha, @situchan Uh oh! This issue is overdue by 2 days. Don't forget to update your issues!
Reviewing label has been removed, please complete the "BugZero Checklist".