Aimane Chnaif

Results 118 comments of Aimane Chnaif

There are 3 cases after login and before loading LHN: 1. full loading page 2. LHN and Report detail page is displayed and all are blank 3. LHN and Report...

I don't think this is correct design we're looking for. It's weird that left side shows skeleton, while right side doesn't show anything. As explained in mockup @shawnborton attached [here](https://github.com/Expensify/App/issues/12698#issuecomment-1314624233),...

> To clarify, would we get rid of the full page loading spinner in lieu of just showing skeleton UI components? @CosminnB your updated [proposal](https://github.com/Expensify/App/issues/12698#issuecomment-1321849840) still doesn't meet this requirement....

@CosminnB we have full page loading spinner after login, before loading main page. Please understand this first. (above screenshot is for Step 1)

@CosminnB The full loading page is 100% displayed every time for me. Please try with HT account. https://user-images.githubusercontent.com/96077027/204366738-e1584fb3-b83f-4c33-99ed-753b861bbe35.mov

> my proposal removes it in favor of showing the skeleton I don't see any code snippet in your proposal related to this.

@CosminnB I followed and tested your updated proposal but still showing blank page on LHN instead of skeleton after login. To ensure that I am not missing anything from your...

I think this has the same root cause as https://github.com/Expensify/App/issues/10414

> ****CLA Assistant Lite bot**** All contributors have signed the CLA ✍️ ✅ @jczekalski no worries. as bot says, you signed already.

@jczekalski don't use rebase merge. too many commits and irrelevant code changes. can you repair PR?