node icon indicating copy to clipboard operation
node copied to clipboard

Release GHA does not trigger GHA CI

Open marco-ippolito opened this issue 8 months ago • 4 comments

Version

No response

Platform

Subsystem

No response

What steps will reproduce the bug?

Opening a release proposal PR with GHA does not trigger the GHA CI workflow. Similar discussions https://github.com/orgs/community/discussions/65321

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior? Why is that the expected behavior?

That it triggers the CI

What do you see instead?

GHA workflows not being triggered

Additional information

Workaround is to use a PAT instead of github token

@nodejs/build @nodejs/releasers

marco-ippolito avatar May 01 '25 14:05 marco-ippolito

Do we create releases with GHA? Not on this repo I don’t think

aduh95 avatar May 01 '25 15:05 aduh95

https://github.com/nodejs/node/pull/57896 this was created by a github bot

marco-ippolito avatar May 01 '25 15:05 marco-ippolito

Do we create releases with GHA? Not on this repo I don’t think

In today's Build WG call we were discussing why https://github.com/nodejs/node/pull/57994 didn't get picked up before https://github.com/nodejs/node/pull/57896 landed. Part of the discussion was the possibility that opening the PR via GitHub Actions (if that was how it was opened) may not trigger other GitHub workflows.

richardlau avatar May 01 '25 15:05 richardlau

Ah you meant opening the release proposal PR, not creating the GH release

aduh95 avatar May 01 '25 16:05 aduh95

https://github.com/nodejs/node/pull/58226 was opened by the workflow and triggered the workflows.

targos avatar May 08 '25 08:05 targos

#58226 was opened by the workflow and triggered the workflows.

To be more precise, opening it did not trigger the workflows, marking it as Ready for reviews did.

aduh95 avatar May 08 '25 08:05 aduh95

Seems to be working as intended to me.

targos avatar May 08 '25 08:05 targos