Antoine du Hamel
Antoine du Hamel
The commit message of https://github.com/nodejs/node/pull/56148/commits/80fcad1c2e36e27809642087c6fda99e32442b18 should say it's a refactor, e.g. ` child_process: refactor string validation in exec and spawn`. The commit message of https://github.com/nodejs/node/pull/56148/commits/2f434320482e72d85d848c58ea482158b7a25c26 should be using `test:` subsystem,...
> 1. Are there plans to change paths on CI machines to something weird, so this issue can be caught immediately? Yes > 3\. Are there any caveats that should...
This does not land cleanly on v22.x-staging, and would require a manual backport PR if we want it on the 22.x line.
@RafaelGSS are you still blocking?
Can you please add https://github.com/nodejs/node/pull/56130 to this backport PR so the correct version is reported for Version 4 section?
Landed in 4f85047aae...ba63702dc3b
> * Github CI is green, but it says failing > > ``` > ? Do you want to proceed anyway? Yes > ✔ Jenkins CI is passing > ✘...
> * When an error happens, we should at least print what are the remaining steps so users can do it manually That seems quite hard to do, because either...
> * It doesn't store state, so after the above error I couldn't start from where I stopped. Hopefully that's not a blocking concern, as I don't think I'll be...
@targos said he wanted to give it a shot, so I'm fine waiting on his input – but also fine landing it if folks think it's ready to land.