Antoine du Hamel

Results 949 comments of Antoine du Hamel

Landed in https://github.com/nodejs/node/pull/55197/commits/1aa71351fabef6ca946cac5fe70bb678feb73be3

> RedYetiDev removed the https://github.com/nodejs/node/labels/needs-ci label Please don't do that, the label is there to inform the bot this PR requires passing Jenkins CI to land > I've added https://github.com/nodejs/node/labels/needs-benchmark-ci...

CITGM (`main`): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3492/ CITGM (this PR): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3493/

I wouldn’t worry about it until the other PR has landed, since this one’s gonna need a rebase anyway

Related Windows failure: ``` --- duration_ms: 399.026 exitcode: 1 severity: fail stack: "\u25B6 findPackageJSON\n \u2714 should throw when no arguments are provided\ \ (2.5201ms)\n \u2714 should throw when parentLocation is...

Note that https://github.com/nodejs/node/pull/55412/commits/d31712c85c6054d0a0106018e0393c1fa0da2eaa is not Windows-related, it's just nits to improve the readability

@JakobJingleheimer rekicking CI won't help until the Windows failures have been taken care of

> on windows it’s outputting a file URL It looks nothing like a `file:` URL, `file:` URL starts with `file://` which clearly does not match `\\?\d:\workspace\…`. That looks more like...

There are still 2 related Windows failures: ``` ✖ should be able to crawl up (CJS) (16.4776ms) TypeError [ERR_UNSUPPORTED_RESOLVE_REQUEST]: Failed to resolve module specifier ".." from "c:\workspace\node-test-binary-windows-js-suites\node\test\fixtures\packages\nested\sub-pkg-cjs\index.js": Invalid relative URL...

> Can this be added to the tsc agenda? What would be the question for the TSC?