Antoine du Hamel
Antoine du Hamel
> So either make it not work in all cases (which is a breaking change) That would certainly be a reasonable option (and the one I would prefer personally), but...
Landed in https://github.com/nodejs/node/commit/4e659be9f8008db9539470e0b33bed6ab5b913b0
Adding https://github.com/nodejs/node/labels/blocked so this PR doesn't land until the next TSC meeting to give folks some time to manifest their opinion if necessary.
@alan-agius4 don't hesitate not to force push when pushing more updates, it creates a poor reviewer experience because GitHub is not able to show the diff since the last review,...
> Should I rebase? Please don't, it wouldn't help in this case. CI failures seem indeed to be unrelated, I've resumed the CI, hopefully that'd be enough to turn it...
@ejose19 Can you please rebase to fix the git conflict?
@ejose19 Can you please rebase and drop the merge commit? Merge commits break our tooling unfortunately.
@legendecas if this is semver-major, do we want to also include the other changes from https://github.com/nodejs/node/pull/44460?
New globals need to be documented in `globals.md`, and an entry for each should be added in `lib/eslintrc.yml` as well.
Now `node --input-type=module -e 'console.log(1)'` is creating the following error: ``` Error: [object Module] could not be cloned. at serialize (node:v8:371:7) at node:internal/modules/esm/worker:81:29 at process.processTicksAndRejections (node:internal/process/task_queues:95:5) ``` We would need...