node
node copied to clipboard
nodejs
lib: don't match `sourceMappingURL` in strings
Prior to this change sourceMappingURL in string where being matched by the RegExp which caused sourcemaps not be loaded when using the --enable-source-maps flag. This commit changes the RegExp to match the last occurrence.
Fixes: https://github.com/nodejs/node/issues/44654
@alan-agius4 don't hesitate not to force push when pushing more updates, it creates a poor reviewer experience because GitHub is not able to show the diff since the last review, it's a bit frustrating to have to "start over" the review again and again. If instead, you push additional commits to the branch, that would be better for me (and all commits will be squashed into one upon landing anyway).
@alan-agius4 don't hesitate not to force push when pushing more updates, it creates a poor reviewer experience because GitHub is not able to show the diff since the last review, it's a bit frustrating to have to "start over" the review again and again. If instead, you push additional commits to the branch, that would be better for me (and all commits will be squashed into one upon landing anyway).
Oops sorry about that. I will keep this in mind for the next time.
This deserves some comments as I don't think it would be obvious to future reader why we use a loop.
Added comments.
Anything needed from my end to make this green? As the failures seems unrelated to this change.
Should I rebase?
Should I rebase?
Please don't, it wouldn't help in this case. CI failures seem indeed to be unrelated, I've resumed the CI, hopefully that'd be enough to turn it green.
This depends on https://github.com/nodejs/node/pull/43875; marking this as "backport-blocked-v16.x"
