Antoine du Hamel

Results 948 comments of Antoine du Hamel

@Farenheith may I ask you to avoid force pushing the PR? It makes it harder to follow what's happening for reviewers. Don't worry, our tooling will squash all subsequent commits...

> I got the guidelines wrong then, sorry. That's not on you, it demonstrates that our docs could use some clarification. Would you be interested in sending a PR that...

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1078/

``` error: patch failed: lib/events.js:27 Falling back to three-way merge... Applied patch to 'lib/events.js' with conflicts. error: patch failed: lib/events.js:27 Falling back to three-way merge... Applied patch to 'lib/events.js' with...

Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1079/ ``` confidence improvement accuracy (*) (**) (***) readline/readline-iterable.js n=10 *** 30.56 % ±7.71% ±10.26% ±13.38% readline/readline-iterable.js n=100 *** 51.98 % ±7.84% ±10.44% ±13.60% readline/readline-iterable.js n=1000 *** 66.41...

Hi @campmedia, thanks for the report. What version of Uppy are you using? And especially what version of `@uppy/informer`? Do you know if it started to happen at some point...

Without a way to reproduce the bug, it's going to be hard to fix it. If you are able to send a minimal repro / share a repo that reproduces...

Hello, this is done: https://hub.docker.com/r/transloadit/companion/tags Let us know if you think we can still improve our release process, or if you see something else missing.

> I think it's likely that we'll move to Vitest for all tests in the Uppy repo. If that happens, I'd rather have Companion on Vitest too, instead of a...

The workaround is to import the individual modules: ```js import DragDrop from '@uppy/vue/lib/drag-drop.js' import StatusBar from '@uppy/vue/lib/status-bar.js' ``` We should probably update the docs to only show imports that targets...