Antoine du Hamel
Antoine du Hamel
@LiviaMedeiros this needs another rebase.
This needs another rebase.
Ping @nodejs/tsc @nodejs/fs for reviews.
Seemingly related CI failure: ``` AssertionError [ERR_ASSERTION]: Expected values to be strictly equal: + actual - expected + '123_456_789.123_456_789_.12_345_678' - '123_456_789.123_456_78' ^ at Object. (/home/runner/work/node/node/test/parallel/test-util-inspect.js:3169:10) at Module._compile (node:internal/modules/cjs/loader:1097:14) at Object.Module._extensions..js...
Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1063/ ``` confidence improvement accuracy (*) (**) (***) util/inspect-array.js type='denseArray' len=100000 n=500 -3.07 % ±5.15% ±6.86% ±8.93% util/inspect-array.js type='denseArray' len=100 n=500 0.65 % ±5.80% ±7.71% ±10.04% util/inspect-array.js type='denseArray_showHidden'...
Related: https://github.com/nodejs/node/pull/31229
> This is a significant blocker for me as Node.js is often used in environment that are constrained by memory. At the bare minimum we should investigate: > > 1....
@arcanis It looks like there are CI failures to address. /cc @nodejs/workers
Why do you use `node:child_process` instead of `node:fs` for file system operations? If you switch to using `node:fs`, it looks like everything works as expected: ```sh mkdir repro && cd...
Ah right, the issue is that Node.js doesn't re-check the FS if there was no `package.json` found. If you write the `package.json` before the first require, it doesn't reproduce: ```...