Antoine du Hamel
Antoine du Hamel
So I tried this branch and got the following errors: ```console $ ./bin/ncu-ci.js resume https://github.com/nodejs/node/pull/43919 ✖ GitHub repository is missing, please set it via ncu-config or pass it via the...
The workflow logs are available at https://github.com/nodejs/node/runs/7530255401?check_suite_focus=true ``` 2022-07-26T22:35:58.0634388Z Requested labels: ubuntu-latest 2022-07-26T22:35:58.0634444Z Job defined at: nodejs/node/.github/workflows/commit-queue.yml@refs/heads/main 2022-07-26T22:35:58.0634463Z Waiting for a runner to pick up this job... 2022-07-26T22:35:58.6965215Z Job is...
> Is this table for the current [nodejs/node#40250](https://github.com/nodejs/node/pull/40250) PR, or a potential future where the assertions are optional? It could be either, considering that no one is supporting implementation nodejs/node#40250,...
> What about adding a new loader hook, which would only return whether the assertion passes or not? That's definitely worth considering. Also maybe something that would correspond to the...
This should work: ```js export function resolve(specifier, context, next) { if(specifier.endsWith('?sha512') || specifier.endsWith('-sha512.mjs')) { const hash = calculateHash(specifier); return { url:`data:text/javascript,export%20default${encodeURI(JSON.stringify(hash)}`, format:'module' }; } return next(specifier, context); } ``` Maybe...
I would like for this to work: ```js export function resolve(specifier, context, defaultResolve) { const nextResult = defaultResolve(specifier, context); if (nextResult.url.endsWith('?sha512') || nextResult.url.endsWith('-sha512.mjs')) { const hash = calculateHash(nextResult.url); return {...
That's very much semver major, `process.exit(-1)` is a common value to indicate an error (https://github.com/search?q=process.exit%28-1%29&type=code), I don't think it's worth breaking at this point.
> I'll do the follow-up after the next major release. Would you be able to open a PR to add a runtime deprecation before the next major? v19.x semver cutoff...
This needs a rebase.
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3026/ CITGM(19.0.0): https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/3023/