Valentin Vignal
Valentin Vignal
Sure I can do that. Can you help me check if there are some useful logs from the commit [debug: Add more prints](https://github.com/flutter/flutter/pull/147212/commits/e9763ce23edf9a7f1c166b5393db21fb0162b59d) ?
@polina-c It looks like [fix: Use ValueListenableBuilder](https://github.com/flutter/flutter/pull/147212/commits/c79ce630dac64b96eb47df3a0d2d726622928570) did the trick 😃
@polina-c I managed to "_fix"_ the tests in `route_test.dart`, I tried to explain them, tell me if something is obscure
@polina-c This was the same as https://github.com/flutter/flutter/pull/147133 but I believe there are some flows in the PR that this one fixes. I think we can keep it open
> You believe it is good, right? I've at least started to convince myself it is good haha 😅 It for sure needs a confirmation from someone with expertise
> @ValentinVignal it looks like there are a lot of changes here unrelated to fixing the leak, some of the changes are identical code, just moved around. I can't actually...
@Piinks @polina-c The changes should have been cleaned now
cc @polina-c
@polina-c I think I just need to not set the animation in the `initState` but in the `didChangeDependencies` only. Hopefully [fix: Don't use dependOnInheritedWidgetOfExactType in the initState](https://github.com/flutter/flutter/pull/147689/commits/6bf33fc251f97da6b47cb7638eee19aeb25a679b) fixes it