Valentin Vignal

Results 94 comments of Valentin Vignal

In my case, I was on macOS and I didn't add ```xml com.apple.security.network.client ``` to `DebugProfile.entitlements` or `Release.entitlements` as explained in the doc: https://pub.dev/packages/google_fonts#http-fetching Adding it solved the issue

It seems like a duplicate of https://github.com/ScerIO/packages.flutter/issues/451 and https://github.com/ScerIO/packages.flutter/issues/448

I'm not sure why the tests for the documentation fail, is there something I didn't do correctly?

Thank you @TahaTesser for this very detailed review! Hopefully I fixed all the issues you found

That is a weird bug, it looks like an animation is not set when running the `build`, but they are supposed to be since it is done in the `initState`...

Sure, I added the `assert`s in [perf: Add debugDispose to snackbar and curved animation](https://github.com/flutter/flutter/pull/147212/commits/0a845a8c7530bb8faaccb8e0d38a98eaa83348d8). Let's see what comes out of it

> perf: Add debugDispose to snackbar and curved animation Sure, I guess I should also remove what was done in [perf: Add debugDispose to snackbar and curved animation](https://github.com/flutter/flutter/pull/147212/commits/0a845a8c7530bb8faaccb8e0d38a98eaa83348d8) (the debug...

@polina-c [ci: Add debug prints to investigate failing ci](https://github.com/flutter/flutter/pull/147212/commits/1d0766e98dff3d2621f5ec0992a45b62c8d4cd30) adds some logs, do they show something in the google internal tests?

🤔 I'm still confused with it haha. I believe the snack bar is getting disposed and for some reason the `AnimatedBuilder` using `_heightAnimation` rebuilds. I can try to add more...