Valentin Vignal

icon indicating a website link https://valentinvignal.github.io/portfolio/

icon company @Novade icon location Singapore icon location Flutter / TypeScript / Svelte / Rust

Results 94 comments of Valentin Vignal

[go_router] Don't log if `hierarchicalLoggingEnabled` is `true`

@chunhtai I refactored `logging` to be able to mock `developer.log` in [refactor: Add mockable developerLog method](https://github.com/flutter/packages/pull/6019/commits/55e67307c20109863a4d2275421b1c96cff83805) and added some tests in [test: Update the tests](https://github.com/flutter/packages/pull/6019/commits/213841feb44823166d3932f77c015074f0a4c487). Is that what you were...

[go_router] Don't log if `hierarchicalLoggingEnabled` is `true`

@chunhtai It should be good now

[go_router] Add documentation to some methods in matching.dart

I would think this is a version exempt ?

[go_router] Add documentation to some methods in matching.dart

> I would think this is a version exempt ? Should the label "override: no versioning needed" be added to this PR ? Or should I create a new version?