Valentin Vignal

Results 94 comments of Valentin Vignal

Hello, is there any news about this ? I am using your API in several projects too

I can not use `_ambiguate` if you want but it will be a breaking change. A project that didn't upgrade to flutter 3 won't be able to use the new...

@creativecreatorormaybenot fair enough, I removed `_ambiguate` in https://github.com/creativecreatorormaybenot/performance/pull/19/commits/c57bbd97379bad6cfdc93c8a92a030e766c89a5b

@creativecreatorormaybenot That is fine, I can do it in this PR. I pushed the changes, tell me if something else needs to be changed.

@creativecreatorormaybenot Is there something else I need to do for it to be merged and released?

The issue is the you are not running your test on iOS or Android. So the condition https://github.com/crazecoder/open_file/blob/2cadda6d282935afce8b02aefe41a198f0c49c0c/lib/src/plaform/open_file.dart#L23 is `true`. If you were running on iOS and Android, mocking the...

Or and idea would be to not use static methods anymore as they are not mockable, you could do something like that: ```dart class OpenFile { OpenFile._(); static OpenFile _instance...

@burhanrashid52 Yes my suggestion is a breaking change, but if you increase the version number to `4.0.0` and mention it in the change logs it should be fine right ?...

> Hmm... Maybe using a static instance inside the static `open` method might solve both issues. It would yes. But for it to be mocked, it would need to use...

hi @incendial , you were too fast for me. I opened the issue https://github.com/dart-code-checker/dart-code-metrics/issues/810 with the wrong account Here is the one I meant to create. Sorry for the trouble....