Valentin Vignal

Results 167 comments of Valentin Vignal

I reverted the changes in [Revert moving progress indicator in the widgets layer](https://github.com/flutter/flutter/pull/170108/commits/6495ef54acd6c7d109c61e658cc98d1225c370aa), I hope this is what you meant :)

@dkwingsmt yes it is read to get another round of review :) @victorsanni also had an open question here : https://github.com/flutter/flutter/pull/170108#discussion_r2330898691

Just saw the tag "your feedback wanted" I understand why `new` could be confusing for beginners, but it seems fair enough from the limitations described. However, we wouldn't be able...

I was wondering, would it work to accept a space` ` ?

@bleroux sure ! I made the change in [revamp: Allow all pointers to scroll](https://github.com/flutter/flutter/pull/157107/commits/ec602ede0ebaade3db3a0f65b5a47b3b20c226c2)

It might be related to https://github.com/Betterment/alchemist/issues/149

@shabanov-krl No 😕

I didn't modify the version number and the CHANGELOG, should I do it or is it not necessary for this?

It looks like the signature needs to be ```dart Future testExecutable(FutureOr Function() testMain) ``` @polina-c do you want me to make a PR to update https://github.com/dart-lang/leak_tracker/blob/main/doc%2Fleak_tracking%2FDETECT.md ?