Valentin Vignal

Results 167 comments of Valentin Vignal

I updated the documentation in https://github.com/dart-lang/leak_tracker/pull/245

Thank you for the insights. https://github.com/flutter/packages/commit/90ee2ca1743ad333e64a261e71620fba2ebcdac5 made the ci pass

@chunhtai I see you added the label "waiting for tree to go green"? Is there a bot that will automatically merge this PR once it is ready (like the flutter...

@chunhtai `packages/packages/pointer_interceptor/` tests keep timing out. Is it from my changes? It looks unrelated to me

I'm super confused. The failing package is `packages/video_player/video_player_android`, `packages/video_player/video_player_android/example/integration_test/video_player_test.dart`. But is passes on my local. Does anyone have any insight about that?

> Does this pr touches video_player package? if not, this may just be an outdated branch, can you try rebase? No it doesn't, that's why I'm having hard time understanding...

It looks like the failing test is also failing on `main`. After it is fixed, this PR should be good to go