Valentin Vignal
Valentin Vignal
This is a _"dummy"_ implementation because I don't know what you would prefer. Do you want me to change the existing `buildPage` method? But it would be a breaking change....
Thank you @chunhtai Should I deprecate `buildPage` ?
I deprecated `buildPage` and the analyzer is failing because of that. What should I do about it? Add `// ignore: ...` ?
@chunhtai I replaced the references in the doc strings and ignore the call to `builPage` in https://github.com/flutter/packages/pull/2444/commits/32b94eb988ab8bdd1d2efb6a0815cf29ab8c57f7
> the go_router_builder may need to be marked //ignore first. I'm sorry, I don't understand what you mean by that
> > the go_router_builder may need to be marked //ignore first. > > I'm sorry, I don't understand what you mean by that @chunhtai is https://github.com/flutter/packages/pull/2444/commits/d5f9c9261eee7860739ae93d44649e3596aba9e3 what you meant ?
> @ValentinVignal the ignore in go_router_builder should be in a separate pr that needs to go in first. Ok, I've create this PR for the ignore in go_router_builder https://github.com/flutter/packages/pull/2504 I'm...
@chunhtai https://github.com/flutter/packages/pull/2504 got merged, so I guess this PR can be re-reviewed
@chunhtai Can I do a merge or does it have to be a rebase?
@chunhtai I merged `main` in my branch in https://github.com/flutter/packages/pull/2444/commits/3802759ddfd06eef5842c7ad2fd89d20b8a18a82 And I think I managed to merge without causing commits hell. Tell me if that is good for you or not