Valentin Vignal

> Great! Can you add test coverage that would catch the issue that you just fixed, in public testing, before internal testing? Sure, the test I added in [test: Add...

It seems like a duplicate of https://github.com/ScerIO/packages.flutter/issues/451 and https://github.com/ScerIO/packages.flutter/issues/448

@polina-c Is there an issue to link this PR to?

``` Because go_router depends on flutter_test from sdk which depends on leak_tracker_flutter_testing 3.0.3, leak_tracker_flutter_testing 3.0.3 is required. So, because go_router depends on leak_tracker_flutter_testing ^2.0.1, version solving failed. ``` But `leak_tracker_flutter_testing...

Great thank you! I changed it in [chore: Use any version for leak_tracker_flutter_testing](https://github.com/flutter/packages/pull/6210/commits/f1804220c9cc50b0f63b2d861dfc7b0ea8b5f56a)

@chunhtai what do you want me to do? Maybe I can remove `leak_tracker_flutter_testing` from the `pubspec.yaml` and revert the `flutter_test_config.dart` but keep the changes to prepare for when `leak_tracker_flutter_testing` can...

I removed the `leak_tracker_flutter_testing` from the `pubspec.yaml` and revert the `flutter_test_config.dart` in [test: Disable leak tracking](https://github.com/flutter/packages/pull/6210/commits/c8d36467b8d00b8d7f789de5b60519c364449a77)

I'm a bit unsure of what I should do, should I stop using `HeroController.dispose` or should I make a change to the pipeline?

@polina-c After looking at it, it is because `HeroControlle.dispose` was released in flutter `3.16.x` - https://github.com/flutter/flutter/pull/133951 - https://docs.flutter.dev/release/release-notes/release-notes-3.16.0 So I had to increase the minimum flutter version of flutter to...

I'm facing the same issue Here is a smaller reproducible code than the original issue: (Or you can checkout https://github.com/ValentinVignal/flutter_app_stable/tree/go-router/can-pop-in-shell) ```dart import 'package:flutter/material.dart'; import 'package:go_router/go_router.dart'; void main() { runApp(const MyApp());...