Hyunjin Song
Hyunjin Song
@spechtstatt It seems like somehow changed tabs to spaces.
> @spechtstatt The use of `std::optional` looks correct, but shouldn't it _replace_ `m_hasColor`? @spechtstatt Could you address that with the indentation fixes(revert to tabs)?
@JohannesLorenz I can't drop OSC models to existing automation patterns because it's not implemented yet. Are you going to implement it?
I also think we should eventually integrate the build script into the LMMS repository prior to merging this, though it has less priority for now.
> It should be enough to change the travis/circle files, such that they > > * clone SPA > * compile and install it > * use `PKG_CONFIG_PATH=...` in front...
Some more issues I've found so far: - `InstrumentTrackWindow::dropEvent` needs some changes to fix compiler warnings and memory leaks, see https://github.com/PhysSong/lmms/commit/e81f9b0a31d7bea3e33511ff6907b548b0dbd31b - SPA fails to build on Mac and for...
> I'd rather not use `ExternalProject_Add`, since it means building LMMS twice Can you elaborate it? I meant building SPA using it.
@Amathadius Which feature do you need the most in the list? We may prioritize the issue if it's valuable enough.
@tresf What's the status of this PR?
> the LV2 plugin isn't aware of the sample rate change for some reason. It seems like `Lv2ControlBase::reloadPlugin` is supposed to handle sample rate change, but the function is not...