Hyunjin Song
Hyunjin Song
FYI, I'm planning to add pitch randomization and unison later. So I afraid `PR` in the artwork may be unclear(P can be either pitch or phase).
TODOs: - [ ] Decide the multiplier to random variables(0\~1 vs. -0.5\~0.5), see https://github.com/LMMS/lmms/pull/4369#discussion_r191114609 - [ ] (Optional?) Restore the behavior of `m_ext_phaseOffset`, see https://github.com/LMMS/lmms/pull/4369#issuecomment-392424837
@iansannar I fixed the merge conflict for you. Please pull it before you go further.
It seems like you removed the `SynchroNote` destructor accidentally. You should either restore it on the source file or add `= default` in the header file to fix the undefined...
To prevent compiler warnings, you should make the order of declaration and initialization consistent.
@iansannar Do you want to add something more here? Or, can I start review?
@iansannar How is it going with sample-exactness? https://github.com/LMMS/lmms/pull/5147#discussion_r329351206
I've resolved merge conflicts and applied minor fixes. Modernization and other reviews are not applied yet. I'll try to continue working on this.