lmms
lmms copied to clipboard
LMMS
Sound of exported LV2 instrument plugins is shifted down one half tone
Bug Summary
When exporting sounds from a LV2 instrument plugin the resulting mp3 or wav file plays this sounds one half tone lower.
Steps to reproduce
- Add a LV2 instrument plugin - e.g. Calf Organ or MDA ePiano
- Create a melody
- Export it as mp3 or wav format (between loop markers)
- Resulting melody plays one half tone lower
Expected behavior
Exported sound from LV2 instrument plugins should match the sound played directly in LMMS
Actual behavior
Exported sound from LV2 instrument plugins are shifted one half tone lower
Affected LMMS versions
Version 1.3.0-alpha.1.149
My guess would be that you run LMMS at 48kHz and export at 44.1kHz, but the LV2 plugin isn't aware of the sample rate change for some reason.
the LV2 plugin isn't aware of the sample rate change for some reason.
It seems like Lv2ControlBase::reloadPlugin is supposed to handle sample rate change, but the function is not implemented yet.
@JohannesLorenz Do you want to fix this?
@JohannesLorenz Do you want to fix this?
I won't fix it before the end of reorg :joy: But if you want to fix it earlier, go ahead.
@spechtstatt I submitted PR #6419. Totally untested. Can you please check?
OK, please don't test. It's causes segmentation faults, I need to fix it.
OK, please don't test. It's causes segmentation faults, I need to fix it.
No problem - thank you for working on it.