Hyunjin Song

Results 188 comments of Hyunjin Song

Yes, you can ignore this. If you're still concerned, you can merge the latest `master` to your branch.

I've investigated this bug further and found the problem. For some reason, `sample->refcount` is negative in https://github.com/FluidSynth/fluidsynth/blob/a85aa9811ca511809964fd55f692120baa362640/src/sfloader/fluid_defsfont.c#L250-L253 when LMMS hangs. This only happens when playing multiple instances of SF2 player...

This issue is much easier to reproduce when you create one track using SF2 player and clone it many times(10 copies were enough in my case).

Quoting a [comment](https://github.com/FluidSynth/fluidsynth/issues/1256) from the upstream: > you keep adding the same `fluid_sfont_t` to multiple synths through `fluid_synth_add_sfont`. But this is illegal. Cf. the API docs of that function: >...

> @PhysSong Are you still working on this? If not, I can try getting it to a state where it's ready to merge. @messmerd No, please feel free to take...

Faders in EQ uses `EqFader` which is a subclass of `Fader`. Themes affect `Fader`, but not `EqFader`. `EqFader` uses a different logic for peak calculation from `Fader`, that might be...

> > Handle signature changes of QAbstractNativeEventFilter::nativeEventFilter in Qt 6 > > Any ideas on what to do here? The last parameter has type of `long` on Qt 5, but...

> PRs are always welcome but if you're on `stable-1.2` it may just be an artifact of that branch. Confirmed. `stable-1.2` has the issue while `master` doesn't. `embedded_resources.h` is removed...

I think we don't need `CMP0050` on `master` because #4421 removed use of `SOURCE`. @lukas-w Right? The `CMP0072` is because root `CMakeLists.txt` doesn't set `FLTK_SKIP_OPENGL` when finding FLTK while `plugins/zynaddsubfx/CMakeLists.txt`...

> Any chance #6780 might have fixed this? No, CMP0072 is introduced in CMake 3.11, and the PR doesn't touch anything related to CMP0072.