Hyunjin Song
Hyunjin Song
@lukas-w Is it ready for review, or do you need to add something more?
@lukas-w Is the commit `Fix macOS linking problem` still relevant? And the changes in `Ubuntu-MinGW-W64.cmake`, too.
Also, are there any plan to add some more benchmark suites? If so, I think having separate `main.cpp` is better.
Just a reminder: `Mixer` at the point of issue creation is now renamed to `AudioEngine`.
`# shellcheck disable=SC2193` will do the job.
What is your Wine version? Also, could you post the output of `grep -i wine CMakeCache.txt` in the build directory? FYI, The errors related to Carla is not related to...
> Fixes #6251 #5885 and #4898 You should add that in the PR body with "fixes" before every issues to auto-close issues on merge. Also, could you handle the merge...
My initial comments: - If I remember correctly, we concluded to remove `shouldApplyMasterGain` from `pushInputFrames` before. - I think it's okay to add more backends in this PR.
I think you should remove `applyMasterGainToInputBuffer` function as well, it's not used anymore after the removal of `shouldApplyMasterGain`.
This issue is specific to windows. We rely on `MINGW_PREFIX` when trying to bundle STK rawwave files. https://github.com/LMMS/lmms/blob/f39b3d50224dcf92ec065a9d05bd39b34396a827/cmake/nsis/CMakeLists.txt#L76-L80 However, the value is not set on the new MinGW toolchain files...