Hyunjin Song
Hyunjin Song
It seems like only `std::experimental::filesystem` is available(in ``) prior to GCC 8 on Linux and XCode 11 on macOS. Also, on Windows, `std::filesystem::path::value_type` is `wchar_t`, so you will have to...
Note for the failure with MinGW: https://stackoverflow.com/a/33159746
> I believe there is something called drum-mapping, which some DAWs support. This enhancement request could help map drums too. Related: #5357
See also: https://github.com/LMMS/lmms/pull/6308#issuecomment-1040131468
I suggest always returning `std::string` and removing code duplication using [`std::string_view`](https://en.cppreference.com/w/cpp/string/basic_string_view).
Well, I mean, you can merge two `encode` functions using `std::string_view` and optionally add `std::string`/`const char*, size_t` variants.
> Also changed the current Qt-based encode/decode namespace to `lmms::gui::base64` Why in `lmms::gui`? We're removing Qt from core, but the base64 methods has nothing to do with GUI. Also for...
It seems like `Track::createTCOsForBB` needs modification as well to make the behavior consistent.
In fact, diminished triad is available as `minb5` and diminished 7th is available as `tri`. I agree, however, those names are not straightforward.
> This uses some Qt5-only features, so it's best to wait with merging this until we've switched Now we've, so I think we can continue working on this. > When...