Hyunjin Song

I wrote an installation logic which should work in most cases(needs testing). ```cmake # Install STK rawwaves if(LMMS_HAVE_STK) find_path(STK_RAWWAVE_ROOT NAMES silence.raw sinewave.raw HINTS "${STK_INCLUDE_DIR}/../.." PATH_SUFFIXES share/stk/rawwaves share/libstk/rawwaves ) if(STK_RAWWAVE_ROOT) file(GLOB...

> This seems more like a `FindStk.cmake` candidate, no? The `find_path` part may reside in the file, but the `install` part shouldn't.

> This would be copying from source, no? I would expect to copy from installation. My intention was to use `/include/stk` as a hint when finding `/share/[lib]stk/rawwaves`.

> I'd expect to use the bottom, not the top, no? Do we even have access to the top? What I'm trying to find is the bottom.

> Could it be that the following define is true on windows (QT_NO_SYNTAXHIGHLIGHTER)? It isn't in MSVC builds, but it is in MinGW builds. Looks like @tobydox [disabled the feature](https://launchpadlibrarian.net/420647900/qt5base-mingw-w64_5.9.8-1.diff.gz)...

> the integrate function relies on long double I can't find any `long double`s in `IntegrateFunction`. I'd say the round-off error in integration of `double` is not a concern compared...

I think your editor is configured to use spaces instead of tabs.

@gnudles BTW, could you resolve the conflicts?

> > Optional should be available by now though, I believe we already bumped to the required C++ version. > > True, but the we have redundant information in `std::optional`...

> Do you see any use case in our code where an invalid `MixerChannel::m_color` and a not-set `MixerChannel::m_color` should be handled differently? No for now, but if we allow setting...