zulip-flutter icon indicating copy to clipboard operation
zulip-flutter copied to clipboard
verified publisher icon zulip

Prep for supporting set typing status

Open PIG208 opened this issue 1 year ago • 1 comments

PIG208 avatar Aug 14 '24 05:08 PIG208

Moved the main commits to #897, so that we can get some earlier independent changes reviewed separately.

PIG208 avatar Aug 20 '24 06:08 PIG208

Thanks for the review @chrisbobbe! I have updated the PR.

  • Dropped fromSendableNarrow to keep the api code from depending on lib/model.
  • Reorganized the tests and made them shorter.
  • Handle the legacy case for FL 215.

PIG208 avatar Aug 22 '24 22:08 PIG208

Pushed to rebase.

PIG208 avatar Aug 22 '24 22:08 PIG208

Thanks! I should push an update later addressing these comments.

PIG208 avatar Aug 23 '24 21:08 PIG208

OK, this has been updated :)

PIG208 avatar Aug 23 '24 22:08 PIG208

Fixed indentation in a test.

PIG208 avatar Sep 05 '24 18:09 PIG208

Pushed to rebase.

PIG208 avatar Sep 07 '24 04:09 PIG208

Dropped the checkDmExpectedOp helper because the TypingOp.toJson is already tested with the typing status for topic tests. Also revised the wording of some tests.

PIG208 avatar Sep 12 '24 21:09 PIG208

Thanks @PIG208, and thanks @chrisbobbe for the previous reviews!

Generally this all looks good. Several comments above, all small.

gnprice avatar Sep 13 '24 08:09 gnprice

Thanks! Pushed an update to the last commit.

PIG208 avatar Sep 13 '24 13:09 PIG208

Thanks! Looks good; merging.

gnprice avatar Sep 16 '24 23:09 gnprice