Zixuan Li comments

Results 238 comments of


                                            Zixuan Li

Handle codehilite elements with multiple classes

Listed under #921.

Handle codehilite elements with multiple classes

For these kind of messages, we should be able to safely apply the style of the most specific known class from the class list. These non-standard token types usually aren't...

local echo (7/7): Support simplified version of local echo

Thanks! Updated this to use 500ms, and rearranged the paddings to avoid displacement.

local echo (7/7): Support simplified version of local echo

This should address comments other than the edit-message-like change; will get to that later. Also rebased on top of the updated "local echo (5/7)" PR, fixing some tests that relied...

local echo (7/7): Support simplified version of local echo

I temporarily removed the last two commits because the confirmation dialog requires us to rework the implementation and tests more.

local echo (7/7): Support simplified version of local echo

Thanks for the reviews! Pushed an update, this time with the commits I removed last time, with a bunch of prep commits. I also went through this PR's interaction with...

local echo (7/7): Support simplified version of local echo

Some visual changes in this update: screenshots The error message for discarding draft on restoring a message not sent is tentative: > When you restore a message not sent, the...

Lint on unawaited futures

Related to discarded_futures: https://github.com/dart-lang/sdk/issues/58889

Case-insensitive topics in unreads data

This issue also applies to `ChannelStore`, where `topicVisibility` is a map that uses `TopicName` as a key. That data structure should also be case-insensitive.

deps: Await/take `flutter_color_models` release that accommodates wide-gamut adjustments to Flutter's `Color`

Thanks for the heads-up. Will prioritize reviewing this once it is ready.