internal_links: Add "/" before fragment identifier
Fixes: #845
This adds a '/ ' after hostname. when this Url is posted in Zulip message it gets linkified.
Thanks for the PR! Left some comments.
PTAL @PIG208
PTAL @PIG208 And thank you for your suggestion.
Thanks @gnprice and @PIG208 for the review. just a small question.
In the current tests, we are dynamically generating and verifying the URL.
Should we be comparing the generated URL directly against a hardcoded, literal full URL string within the test (e.g., including specific realm URLs and message IDs), rather than dynamically building it?
Yes. As the issue says:
we should also add a few tests that include, verbatim, the full URL they expect as the output.
For further questions about how to complete the PR, I recommend a chat thread in #mobile-dev-help. That may get a faster response.
PTAL @PIG208
PTAL @PIG208
Please review @gnprice.