Michael Hoffmann

Results 224 comments of Michael Hoffmann

I think this is done - we are on Prometheus 3 now and we pass acceptance tests ( and all the others ). I'll close - if I misunderstood please...

There was a bug in the distributed query engine where we didn't propagate matchers correctly. I think that should be fixed in this but just to make sure... Is this...

Is Perses not compatible with Grafana dashboard JSON definitions?

@MXfive can you please sanity check? - it seems to work on your provided testcases and seems reasonable generally, but just in case i missed something!

Thank you I'll bump the Terraform grammar then too and prepare a release in a bit

> @MichaHoffmann I just ran into this issue; is there something I can do to help get this merged? Hey :wave:, I rebased on latest main and added the fix...

We fail here: https://github.com/tree-sitter/node-tree-sitter/blob/3343ab8cf99540caf792eb69a29c243defffa983/index.js#L858 so i guess the node bindings are not compatible with code generated by the latest tree-sitter cli? Edit: needed to bump tree-sitter node to 0.25.0

> Looks like an issue with the `swift-tree-sitter` bindings. Try removing these lines: > > https://github.com/tree-sitter-grammars/tree-sitter-hcl/blob/009def4ae38ec30e5b40beeae26efe93484ab286/.github/workflows/ci.yaml#L41-L46 > > If that fails, just remove the Swift bindings from the test. didnt...

Since this flag is experimental i dont mind if we merge this and followup with fixes later

Operators have the Series() method - that and the series id should be enough to get all labels - some won't have metric name anymore though because of prior aggregations...