Michael Hoffmann comments

Results 224 comments of


                                            Michael Hoffmann

Expose the ability to disable errorVerbose via logger config

I have something like, to minimize conversion pain: ``` type plainError struct { e error } func (pe plainError) Error() string { return pe.e.Error() } func PlainError(err error) zap.Field {...

Expose the ability to disable errorVerbose via logger config

I'm sorry, then i'm out of ideas! edit: I just had the idea that one can offload that task to the encoder maybe.. something like this could work ``` type...

Expose the ability to disable errorVerbose via logger config

the stacktrace at the time of logging is saved in `ent.Stack` you could combine it with the one of the `stackTracer`.

get current master is not working in one scenario with redis-sentinel configuration

We also hit that issue in production. After some debugging, it seems that the masterAddress is updated via the "+switch-master" subscription in the `MasterListener` of `JedisSentinelPool`, or on some connection...

Receiver: Running with number of replicas lower than replication factor in a hashring is accepted

Created #6168 for it now.

Receiver: Running with number of replicas lower than replication factor in a hashring is accepted

> Was there any fix for this issue ? I am also experiencing the same with 0.32.5 Version of thanos. Are you experiencing deadlock or does receiver fail to start...

Thanos Sidecar - Flush Endpoint

There was some idea to run prometheus via libraries from within sidecar; that way we could build this properly. cc @SuperQ

Query: Fixing extended functions in distributed querier

LGTM, can you separate the prometheus import from stdlib imports though please?

Thanos sidecar doesn't upload full blocks

Hey! Out of curiosity: how does meta.json look for a broken block? Does it only contain the chunks that are actually there uploaded?

Thanos sidecar doesn't upload full blocks

Hey @bobykus31, are you able to share the blocks by chance?