Michael Hoffmann

Results 224 comments of Michael Hoffmann

The difference is only dots in identifiers? I think we could just support that here! Can you raise PR? Dialect is not official concept but you can just inherit grammar...

This is for nvim-treesitter, right? Or is there another usecase for dialects?

Oh if this isn't canonical setup then we can totally change it! It grew as my personal project so I just went along with what made sense at the time!...

Sorry for taking so long - it has been hard finding time during the work week recently! Thank you for the contribution!

I wonder if we should move the website and its build to cloudflare pages

Can we just wrap the matrix function into step invariant operator? https://github.com/thanos-io/promql-engine/blob/main/execution/step_invariant/step_invariant.go#L47 ?

We could just push step inviarnace up in a preprocessor like here: https://github.com/thanos-io/promql-engine/blob/main/logicalplan/plan.go#L335

I see, I wonder if we maybe should jsut fall back for now for correctness sake - this seems to be fairly niche usecase that we must weigh against added...